<html>
<head><meta charset="utf-8"><title>Better Capture Analysis loggin · t-compiler/wg-rfc-2229 · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/index.html">t-compiler/wg-rfc-2229</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html">Better Capture Analysis loggin</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="213970149"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/213970149" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#213970149">(Oct 20 2020 at 19:44)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span>  Last week we had discussed that we want to A make the analysis being logged short and concise and at the same time output it to stderr. </p>
<p>To do the latter part, do you have any suggestions? I was thinking using the <a href="https://doc.rust-lang.org/nightly/nightly-rustc/rustc_errors/diagnostic_builder/struct.DiagnosticBuilder.html">DiagnosticsBuilder</a>  with notes and then setting the span to that of the closure expression</p>



<a name="213970934"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/213970934" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#213970934">(Oct 20 2020 at 19:51)</a>:</h4>
<p>that would work, I was also imagining building a <code>String</code> that goes into the error message</p>



<a name="213970956"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/213970956" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#213970956">(Oct 20 2020 at 19:51)</a>:</h4>
<p>another option I guess would be to put separate errors on the various lines</p>



<a name="213970963"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/213970963" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#213970963">(Oct 20 2020 at 19:51)</a>:</h4>
<p>i.e., "captured x.y because of this span"</p>



<a name="213970970"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/213970970" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#213970970">(Oct 20 2020 at 19:51)</a>:</h4>
<p>that seems pretty useful</p>



<a name="213971002"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/213971002" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#213971002">(Oct 20 2020 at 19:51)</a>:</h4>
<p>I was thinking about that aswell, but I'm wondering if the compiler would stop because of previous errors in that case</p>



<a name="213971886"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/213971886" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#213971886">(Oct 20 2020 at 20:00)</a>:</h4>
<p>notes are ok too, the only catch with notes is that I sort of forget whether the test harness enforces that they are all annotated. I think what it does is to say that if you annotate <em>any</em> notes, you must annotate <em>all</em> notes</p>



<a name="213971944"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/213971944" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#213971944">(Oct 20 2020 at 20:00)</a>:</h4>
<p>in any case the compiler doesn't ordinarily stop because of previous errors,</p>



<a name="213971966"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/213971966" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#213971966">(Oct 20 2020 at 20:00)</a>:</h4>
<p>especially because for these tests I'd expect you to have just one test function</p>



<a name="213972377"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/213972377" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#213972377">(Oct 20 2020 at 20:03)</a>:</h4>
<p>In that case I think span will be better, just because it verifies more details about the analysis</p>



<a name="213974016"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/213974016" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#213974016">(Oct 20 2020 at 20:17)</a>:</h4>
<p>Do we want to print both passes of the capture analysis (gather info on place and then min capture) or just the final result? </p>
<p>I was thinking of two in case min capture masks some errors in the first pass</p>



<a name="213975335"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/213975335" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#213975335">(Oct 20 2020 at 20:29)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116009">nikomatsakis</span> <a href="#narrow/stream/189812-t-compiler.2Fwg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin/near/213970956">said</a>:</p>
<blockquote>
<p>another option I guess would be to put separate errors on the various lines</p>
</blockquote>
<p>Actually, how do we do multiple span_bugs, isn't that essentially exit after the reporting? Or was the suggestion to do multiple span things in Diagnostic builder?</p>



<a name="213991061"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/213991061" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#213991061">(Oct 20 2020 at 23:17)</a>:</h4>
<p><a href="https://github.com/rust-lang/project-rfc-2229/issues/19">https://github.com/rust-lang/project-rfc-2229/issues/19</a></p>



<a name="214099839"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/214099839" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#214099839">(Oct 21 2020 at 19:10)</a>:</h4>
<p><span class="user-mention silent" data-user-id="281950">Aman Arora</span> <a href="#narrow/stream/189812-t-compiler.2Fwg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin/near/213975335">said</a>:</p>
<blockquote>
<p><span class="user-mention silent" data-user-id="116009">nikomatsakis</span> <a href="#narrow/stream/189812-t-compiler.2Fwg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin/near/213970956">said</a>:</p>
<blockquote>
<p>another option I guess would be to put separate errors on the various lines</p>
</blockquote>
<p>Actually, how do we do multiple span_bugs, isn't that essentially exit after the reporting? Or was the suggestion to do multiple span things in Diagnostic builder?</p>
</blockquote>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span></p>



<a name="214121928"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/214121928" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#214121928">(Oct 21 2020 at 22:16)</a>:</h4>
<p><span class="user-mention" data-user-id="281950">@Aman Arora</span> oh I wouldn't do <code>span_bug</code>, just <code>span_err</code></p>



<a name="214122232"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/214122232" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#214122232">(Oct 21 2020 at 22:19)</a>:</h4>
<p>Sounds good, thank you</p>



<a name="216650295"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216650295" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216650295">(Nov 13 2020 at 18:13)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> if we use span notes does that not mean if stderr changes the user doesn't need to updated the test src file?</p>



<a name="216650421"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216650421" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216650421">(Nov 13 2020 at 18:14)</a>:</h4>
<p><span class="user-mention" data-user-id="281950">@Aman Arora</span> I think if you add <code>//~ NOTE</code> annotations, then you must annotate <em>all</em> the notes</p>



<a name="216650432"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216650432" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216650432">(Nov 13 2020 at 18:14)</a>:</h4>
<p>but if you don't, you don't</p>



<a name="216650447"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216650447" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216650447">(Nov 13 2020 at 18:14)</a>:</h4>
<p>so it can be done either way</p>



<a name="216650525"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216650525" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216650525">(Nov 13 2020 at 18:15)</a>:</h4>
<p>Okay sounds good</p>



<a name="216668594"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216668594" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216668594">(Nov 13 2020 at 20:30)</a>:</h4>
<p>PR updated, should be good now <span class="user-mention" data-user-id="116009">@nikomatsakis</span></p>



<a name="216673850"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216673850" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216673850">(Nov 13 2020 at 21:15)</a>:</h4>
<p><span class="user-mention" data-user-id="281950">@Aman Arora</span> nice</p>



<a name="216811853"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216811853" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216811853">(Nov 15 2020 at 20:15)</a>:</h4>
<p>So the PR fails to build clippy. Why it breaks is here: <a href="https://github.com/rust-lang/rust/pull/78801#issuecomment-727616809">https://github.com/rust-lang/rust/pull/78801#issuecomment-727616809</a></p>



<a name="216815462"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216815462" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216815462">(Nov 15 2020 at 21:33)</a>:</h4>
<p>I'll be pushing a change that also check closure_captures as a fallback in case min_captures is empty</p>



<a name="216815578"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216815578" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216815578">(Nov 15 2020 at 21:35)</a>:</h4>
<p>My reasoning behind this is:</p>
<ul>
<li>Let's not increase memory usage throughout the compiler run (maybe incremental cache as well -- idk what all gets written)</li>
<li>We are keeping pieces of code post-typeck to use closure_captures, so it _kind of_ makes sense to do the same for ExprUseVisitor.</li>
</ul>



<a name="216869619"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216869619" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216869619">(Nov 16 2020 at 13:25)</a>:</h4>
<p>The eventual intent is to remove <code>closure_captures</code>, right?</p>



<a name="216869638"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216869638" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216869638">(Nov 16 2020 at 13:25)</a>:</h4>
<p>And at that point, we would writeback <code>min_capture_closures</code> and friends?</p>



<a name="216901121"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216901121" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216901121">(Nov 16 2020 at 17:09)</a>:</h4>
<p>Yeah, project-rfc-2229#18 is there for this specific thing</p>



<a name="216915666"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216915666" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216915666">(Nov 16 2020 at 18:57)</a>:</h4>
<p>OK, in that case i'm ok with this change</p>



<a name="216915724"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216915724" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216915724">(Nov 16 2020 at 18:58)</a>:</h4>
<p><span class="user-mention" data-user-id="281950">@Aman Arora</span> did you impl what you described above?</p>



<a name="216915770"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216915770" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216915770">(Nov 16 2020 at 18:58)</a>:</h4>
<p>yeah it's on PR</p>



<a name="216915847"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216915847" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216915847">(Nov 16 2020 at 18:58)</a>:</h4>
<p>above as in, in the chat not on the issue</p>



<a name="216915929"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216915929" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216915929">(Nov 16 2020 at 18:59)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/78801/commits/bb8c5e5d8b4961a26f88b320f719249a9db8225e">https://github.com/rust-lang/rust/pull/78801/commits/bb8c5e5d8b4961a26f88b320f719249a9db8225e</a></p>



<a name="216916277"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216916277" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216916277">(Nov 16 2020 at 19:02)</a>:</h4>
<p><span class="user-mention" data-user-id="281950">@Aman Arora</span> great, left a nit</p>



<a name="216916346"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216916346" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216916346">(Nov 16 2020 at 19:02)</a>:</h4>
<p>I didn't want to add that to the function docs. It's two comments below</p>



<a name="216916367"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216916367" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216916367">(Nov 16 2020 at 19:02)</a>:</h4>
<p>Or do you want FIXME(issue-num)</p>



<a name="216916669"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216916669" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216916669">(Nov 16 2020 at 19:05)</a>:</h4>
<p>oh, I missed it</p>



<a name="216916680"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216916680" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216916680">(Nov 16 2020 at 19:05)</a>:</h4>
<p>as long as it says FIXME somewhere it's ok, but link to the issue would be great</p>



<a name="216916780"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216916780" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216916780">(Nov 16 2020 at 19:06)</a>:</h4>
<p>yeah that's there</p>



<a name="216929219"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216929219" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216929219">(Nov 16 2020 at 20:43)</a>:</h4>
<p>heads up: do the other tools build with this PR (I don't think it was the case on the earlier <code>try</code> build) ? if not, it might still not land since we're still in the no-tool-breakage week</p>



<a name="216929830"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216929830" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216929830">(Nov 16 2020 at 20:49)</a>:</h4>
<p>I didn't try building all of them locally. What I got from t-infra was I can modify some CI scripts to test certain components. I don't know if there is value in doing it now (comparing to a week ago), since by the time I can get to this CI would already run</p>



<a name="216929936"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216929936" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216929936">(Nov 16 2020 at 20:50)</a>:</h4>
<p>yeah I wouldn't think so -- the PR will be fully tested in a couple hours and we'll know soon enough</p>



<a name="216930013"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216930013" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216930013">(Nov 16 2020 at 20:50)</a>:</h4>
<p>in any case it will still be able to land in a couple days :)</p>



<a name="216930072"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216930072" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216930072">(Nov 16 2020 at 20:51)</a>:</h4>
<p>Yeah <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<a name="216971047"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/189812-t-compiler/wg-rfc-2229/topic/Better%20Capture%20Analysis%20loggin/near/216971047" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/189812-t-compiler/wg-rfc-2229/topic/Better.20Capture.20Analysis.20loggin.html#216971047">(Nov 17 2020 at 06:49)</a>:</h4>
<p>Okay it didn't break anything else ^_^</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>